Jump to content

Wikipedia:Code review/UTCLiveClock

From Wikipedia, the free encyclopedia

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.


UTCLiveClock

[edit]

Current code: mw:MediaWiki:Gadget-UTCLiveClock.js

Proposed new code: mw:Special:Permalink/3845287

Changes to code: mw:Special:Diff/3845287

Summary of changes:

  • Add support for timezones other than UTC by allowing the user to specify `window.LiveClockOffset` in their js (hours relative to UTC). No change in functionality if not set

Specific issues / areas for feedback:

Thanks, DannyS712


Discussion
  • I personally would like to see this feature on the enwiki. I have facepalmed myself for using it as a clock instead of looking at my computer for the current time and I am not good at math. Galendalia CVU Member \ Chat Me Up 11:24, 11 May 2020 (UTC)[reply]
Discussion part 2

@MusikAnimal, Writ Keeper, and Jonesey95: I rewrote my update. Net changes: mw:Special:Diff/3845284/3880447 - new code: mw:Special:Permalink/3880447. This uses timezone names, the option is LiveClockTimeZone, and it should capture the issues discussed above. Thoughts? Thanks, --DannyS712 (talk) 12:33, 28 May 2020 (UTC)[reply]

I'm definitely looking forwards to this, if it's not too much trouble please ping me when it's finished. Doug Weller talk 08:15, 7 June 2020 (UTC)[reply]
Thanks for incorporating my suggestions. I have no further comments. I haven't tested it. – Jonesey95 (talk) 14:02, 7 June 2020 (UTC)[reply]
Last call before I merge the changes - any objections? --DannyS712 (talk) 20:05, 30 June 2020 (UTC)[reply]
I've merged the changes --DannyS712 (talk) 17:48, 20 July 2020 (UTC)[reply]
The discussion above is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.