Wikipedia talk:WikiProject Articles for creation/tabs

Think carefully before removing closing tag

CanonNi: I don't know what's going on here. All I know is that if you remove a </div> from a template, that's going to cause a missing end tag for every page that uses the template. You would then have to edit each such page and insert the missing </div>. Is that what you want to do? —Anomalocaris (talk) 18:40, 6 October 2024 (UTC)

I assume you're referring to Special:Diff/1249328456, in which an opening div was added, not a closing div removed. I do agree, though, making that addition means that every page calling this template needs to have an additional closing div tag added to it. I will note that we have a weird div setup because the headers and text are wrapped in the divs of the tabs, so they're all closed separately. It makes me think that we should have a /tabs/close template that holds these closing divs so that if a change is made to this template a single edit to the "closing" template will fix all of the issues. Primefac (talk) 18:45, 6 October 2024 (UTC)

As a note, I've now done this. Good to reinstate the invert diff I linked above? Primefac (talk) 18:58, 6 October 2024 (UTC)

Primefac: Yes, that edit. I spotted the added </div> in the <noinclude>...</noinclude> region, and I didn't spot the <div> at the top. I saw there was a problem with missing </div> in calling pages, so I was obviously confused about multiple issues here, and I'm glad you were able to sort it out. Your fix seems to be a good solution. —Anomalocaris (talk) 19:48, 6 October 2024 (UTC)

Coolio. I've restored the skin invert on the main template and updated the subpage. Let me know if anything borks as a result. Primefac (talk) 19:52, 6 October 2024 (UTC)

@Anomalocaris and Primefac: thanks for fixing that. I really need to work on my template skills... Anyways, here's an obligatory  Self-trout. '''[[User:CanonNi]]''' (talk • contribs) 00:56, 7 October 2024 (UTC)