Wikipedia:Bots/Requests for approval/Svenbot 4

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Approved.

Svenbot 4

Operator: Sven Manguard (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 15:21, Friday July 13, 2012 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): Java, more Java, some extra Java sprinkled on top, and a side of Java

Source code available: Right now it's not available, but it will be before the end of Wikimania

Function overview: I'm taking over

Links to relevant discussions (where appropriate): See above BRFA links.

Edit period(s): Varies. All will run on crons, based on how current they need to be.

Estimated number of pages affected: Varies. 14 and 15 will be several dozen a month, the others less.

Exclusion compliant (Yes/No): Yes

Already has a bot flag (Yes/No): Yes

Function details: See above BRFA links.

Discussion

When you say the source code is on labs somewhere, you think, does that mean you wrote the code or you're using Fastily's code? If the latter, all of these tasks should be exclusion-compliant. Are you changing the code at all? — madman 15:43, 13 July 2012 (UTC)[reply]

Based on what I see here it is Fastily's code. Also because I was also hammered and scrutinized about this, and I still am, I don't see Sven Mangaurd understands the code yet and shouldn't be allowed to operate it until he does.—cyberpower ^Chat_Online 15:49, 13 July 2012 (UTC)[reply]

What evidence do you see of that? This request was just submitted and we just started discussion. — madman 16:52, 13 July 2012 (UTC)[reply]

I do understand exactly what the code is supposed to do, know how to tell if it's doing that correctly, etc. The reason that I put the question mark in there is that I had to wait until the presentation I was in was over to make sure. I was sitting in a Wikimania room with my 10 pound laptop on my knees and no mouse. If you wait a while I can get you more details. My bad. Sven Manguard Wha? 17:40, 13 July 2012 (UTC)[reply]

It's no problem. There's no deadline. :p — madman 17:52, 13 July 2012 (UTC)[reply]

Oh. I take that back then. Sorry.—cyberpower ^Chat_Online 19:29, 13 July 2012 (UTC)[reply]

Yes, it is exclusion comparable. I can't see why it was even a question, as it was before. Sven Manguard Wha? 19:34, 13 July 2012 (UTC)[reply]

I see no concerns here. It was a previously approved task.—cyberpower ^Chat_Online 19:40, 13 July 2012 (UTC)[reply]

If there are no modifications to the already approved implementations,

Approved for trial (25 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. for each task, just to make sure the implementations continue to work in a new environment. Cheers, — madman 20:03, 13 July 2012 (UTC)[reply]

Errr... about that. They've already been running... for a day and a half by now. No errors in my spot checks. Since I'm at Wikimania with the labs staff, I wanted to make sure it worked while they were around. Also, there were a few hours there that I forgot that I didn't already have approval for the tasks other than 2 and 4. My bad. Sven Manguard Wha? 20:08, 13 July 2012 (UTC)[reply]

I'll let that slide (as there were no problems) and just say starting from now, 25 of each task (125 total). Let us know when you're done. Rcsprinter (whisper) @ 20:21, 13 July 2012 (UTC)[reply]

I've brought everything down, because that's just easier that waiting for the slowest one to reach 25. They've all done well over than 25 by now. Sven Manguard Wha? 20:45, 13 July 2012 (UTC)[reply]

Approved. This is a duplicate of already approved tasks, so there should be no issues in terms of the edits themselves; the trial has been run and no issues have been found. The bot running unapproved is unfortunate, but I understand this was an accident/miscommunication as Sven wanted to make sure the bot would be able to run while he was at Wikimania (and able to contact the people at Labs able to help him troubleshoot). He has assured that this sort of thing won't happen again. — The Earwig ^(talk) 14:37, 14 July 2012 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.