Wikipedia:Bots/Requests for approval/B-bot 4

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Approved.

B-bot 4

Operator: B (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 11:11, Friday, May 29, 2015 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): C#

Source code available: User:B-bot/source/Expired OTRS pending tagger

Function overview: If an image has been tagged with {{OTRS pending}} longer than {{OTRS backlog}} days, tag the image with {{subst:npd}} and warn the uploader with {{subst:di-no permission-notice-final}}.

Links to relevant discussions (where appropriate): Wikipedia:OTRS_noticeboard#Proposal_to_move_to_dated_pending_and_received_categories

Edit period(s): Daily

Estimated number of pages affected: Capped at 10 files per day (for now) so as to not overwhelm the daily deletion queues.

Exclusion compliant (Yes/No): Yes

Already has a bot flag (Yes/No): Yes

Function details: This task patrols Category:Items pending OTRS confirmation of permission by date for images that have been tagged with {{OTRS pending}} longer than {{OTRS backlog}}.

If the {{OTRS pending}} tag contains either the date parameter or month|day|year parameters, then we will use that as the tagging date. (Once Wikipedia:Bots/Requests for approval/B-bot 3 is approved, all images this job ever processes will have month|day|year tags in place.) If neither tag is in place, then we will treat the last revision date as though it was the date that {{OTRS pending}} was added.

In computing the expiration time, we will always wait at least 30 days, even if the backlog is under 30 days. (WP:CSD#F11 only permits deletion of images with {{OTRS pending}} that have been tagged more than 30 days.)

We will also include a grace period of 7 days beyond the backlog time (under the theory that you might add {{OTRS pending}} before actually forwarding the messages to the permissions account) and will add to that number the number of days since the {{OTRS backlog}} template was updated.

In other words, suppose that the template says there is a backlog of 50 days. The template was updated 2 days ago. We will only tag images with {{subst:npd}} if they have been tagged with {{OTRS pending}} for 50 + 2 + 7, or, 59, days.

When an image is tagged, we notify the uploader with a new template - {{subst:di-no permission-notice-final}}. The purpose of this template is to NOT inundate the user with scary copyright symbols or 1000 policies to read. It delivers a very simple message that looks like a human actually wrote it - please forward the email and let us know you have done so. (The hope is that for users whose eyes glaze over at the copyright templates will be able to understand this straight forward message.)

Discussion

A test is underway at User:B-bot/Test page. --B (talk) 11:11, 29 May 2015 (UTC)[reply]

It says that you are skipping pages in Category:Candidates for speedy deletion and Category:Wikipedia files missing permission. Please also skip files in Category:All non-free media. If a non-free file has been tagged with {{OTRS pending}}, it may be better to do a manual review and either remove the {{OTRS pending}} template or tag the file as violating the non-free content criteria. Tagging as 'no permission' will not be correct and may confuse the uploader. Please also skip files in Category:Items with OTRS permission confirmed. Sometimes, a file may have multiple OTRS tags with conflicting information, and these are also to be checked manually to avoid confusion. Maybe you could report files in these two categories to the event log?

When reading the date parameter, you use dtmDate = DateTime.Parse(arrNameValue[1]). Which date formats are allowed here? For example, {{OTRS pending}} allows the date to be entered as ~~~~~, which is a somewhat unusual date format but easy for Wikipedians to use.

{{subst:npd}} has a source parameter, and "OTRS pending" files have sometimes been tagged with {{subst:npd|source={{NoOTRS60}}}}. Would it be a good idea to put something in the source parameter, for example 'Tagged with {{OTRS pending}} for 123 days'?

Can you provide a log of all tagged files somewhere? It could be useful to check after one week has passed to see if there are some files which were not deleted but which should have been deleted, for example because the uploader removed some templates.

This is only about {{OTRS pending}} but not about {{OTRS received}}, right? --Stefan2 (talk) 21:02, 29 May 2015 (UTC)[reply]

Yes. At OTRSN, we haven't really decided on what to do for OTRS received. --B (talk) 01:38, 30 May 2015 (UTC)[reply]

@Stefan2: (1) I have added the categories you mentioned. (2) I have changed my npd tag to {{subst:npd|source={{NoOTRS60|days={{subst:OTRS backlog}}}}}}. (3) DateTime.Parse() will accept any of the standard formats shown at [1] as en-US formats. All of these work correctly: "1/20/1983", "1983-10-20", "December 3, 2010", "15 JUN 2009". It will not handle Euro dates (today is 29/05/2015 in Europe) because, obviously, those are indistinguishable from US ones (05/01/2015 = May 1 in the US and January 5 in Europe). But I imagine that the Wikipedia software does the same thing. {{#time:Y-m-d|5/1/1983}} (1983-05-01) shows up as May 1, 1983 for me, and hopefully for everyone, or else we have some real problems with the software. (4) The log is on my to do list. It's independent of this process because we still want to log even those images where someone manually puts in the date themselves. --B (talk) 02:08, 30 May 2015 (UTC)[reply]

There is no 'European' date format as each European country has its own date format. I'm mainly concerned about {{#time:~~~~~}} which is accepted as 2015-05-30. This date format is not listed on that Microsoft page. --Stefan2 (talk) 06:28, 30 May 2015 (UTC)[reply]

I have added support for that string. --B (talk) 12:20, 30 May 2015 (UTC)[reply]

@Magioladitis: The dated filer has now completed its run. Can I do a trial of this one? At least for now (and maybe forever?) it is capped at 10 image taggings per day so as to not overwhelm the CSD category. (Each tagging will normally have a notification unless the intended recipient has opted out, for a total of 20 edits per run.) --B (talk) 14:38, 4 June 2015 (UTC)[reply]

Approved for trial (50 edits or 5 days). Please provide a link to the relevant contributions and/or diffs when the trial is complete. -- Magioladitis (talk) 14:40, 4 June 2015 (UTC)[reply]

Trial complete.

@Magioladitis: The logs from the three runs are here, here, and here. The edits are here, here, and here. In two cases, the notifications successfully led to responses from the uploaders at the OTRS noticeboard and they contacted us via the OTRS system. --B (talk) 15:11, 6 June 2015 (UTC)[reply]

Another success story: for File:Portrait of Nancy Buchanan.jpg, we received an email in the OTRS system following the final warning. --B (talk) 11:22, 9 June 2015 (UTC)[reply]

Approved. -- Magioladitis (talk) 22:13, 11 June 2015 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.