Jump to content

User:MarkAHershberger/Weekly reports/2010-W14

From Wikipedia, the free encyclopedia

JS2 Branch

[edit]

This week I started looking at the js2 branch and seeing what could be moved into modules in order to help deploy the code in usable chunks rather than one gigantic code blob being added to core.

Mdale and I had a discussion in CodeReview on r64451 about this, clarifying the bits and pieces of the js2 work that were supposed to go into core (e.g. OutputPage.php) and the bits that I thought could be modularized.

He seems to agree that mwEmbed could easily be put into an extension but was concerned about the work on OutputPage.php.

WatchList param refactoring

[edit]

After looking over r64197 I saw inconsistencies in how watches were set: some used an article object and some used wgUser. The difference between these could cause subtle bugs since there are hooks called on the article object watches that aren't called on the wgUser calls. That and the cut-n-paste coding style irritated me. I refactored this and added some tests.

The testing pointed out a bug in the code (See r64850) and allowed me time to gain a little more familiarity with the API code.

Upcoming Work

[edit]

Tim reminded me of the Asynchronous Download code that still needed to be put into an extension. While I didn't have time to do this last week, I plan on focusing my efforts on it this week. I should have a much better understanding of the JobQueue at the end of the week.