Template talk:WikiProject Military history

WikiProject banner shell

What progress are we making on getting Template:WikiProject Military history to get it to inherit from Template:WikiProject banner shell? Seems to be a lot of unecessary bot work going on just dealing with this. Hawkeye7 (discuss) 20:15, 17 January 2024 (UTC)

Anomalous rating

@Harryboyles: Looking at Talk:Ironclad warship, the WikiProject Banner Shell is set to C class, but this is not being inherited by the WikiProject Military history banner, which for some bizarre reason is showing the article as Start class, although there is no class parameter. This causes weird effects, with the article being categorised as both C and Start class. Any idea where the start comes from? And how we can get the banner to inherit correctly? Hawkeye7 (discuss) 22:23, 31 March 2024 (UTC)

From the template page: WikiProject Military history has opted out of project-independent quality assessments and is using a custom class mask. With the article being recently demoted from A-class, the automatic class rating from the class mask applies. There's no B-Class assessment checklist done (B-Class-1 through B-Class-5 parameters), so the default case of Start-class applies. Wikipedia:WikiProject Military history/Assessment#Criteria lists the criteria required for C-class (The article meets B1 or B2 as well as B3 and B4 and B5 of the B-Class criteria.) and B-class (The article meets all of the B-Class criteria.) Harryboyles 23:03, 31 March 2024 (UTC)

If there is no B-Class assessment checklist done, then the article should be in Category:Military history articles with missing B-Class checklists. The bot will then assess it. I don't know why it is not. The default is for unassessed articles is to be placed in Category:Unassessed military history articles. WikiProject Military history has not opted out of quality assessments. I will see if we can get that message corrected. Hawkeye7 (discuss) 23:57, 31 March 2024 (UTC)

@Hawkeye7: Harryboyles didn't say that milhist had opted out of quality assessments; they said WikiProject Military history has opted out of project-independent quality assessments, please note the qualifier "project-independent" here. Quality assessments still occur, but need to be set on the milhist banner as well as on the banner shell. --Redrose64 🌹 (talk) 05:57, 1 April 2024 (UTC)

The project should inherit the rating from the banner shell where it is set. Hawkeye7 (discuss) 07:03, 1 April 2024 (UTC)

@Redrose64: When QUALITY_CRITERIA=='custom' and there is no class set, the module is supposed to "replace class with inherited class". Hawkeye7 (discuss) 07:45, 1 April 2024 (UTC)

if args.QUALITY_CRITERIA=='custom' then -- project has opted out of standard assessment scale and uses a custom mask
		local custom_mask = banner_name:subPageTitle('class')
		if custom_mask.exists and #custom_mask:getContent()>1 then
			raw_args.demo_page = args.demo_page -- send demo_page to custom mask
			class = mw.text.trim(frame:expandTemplate{
				title = custom_mask.prefixedText,
				args = raw_args
			})
			if class=='' and article_class and article_class~='' then -- if unassessed and article class exists, check if it can be inherited
				local new_arg_table = {}
				for arg, val in pairs(raw_args) do -- construct new argument table to send to custom mask
					new_arg_table[arg] = val
				end
				new_arg_table.class = article_class -- replace class with inherited class
				local article_class_normalised = mw.text.trim(frame:expandTemplate{
					title = custom_mask.prefixedText,
					args = new_arg_table
				})
				if article_class_normalised and article_class_normalised~='' then
					class = article_class_normalised -- inherit class from article_class normalised by custom mask
				else
					article_class = nil -- effectively no article_class for this banner
				end
			end
		end
}}

Hawkeye7 (discuss) 07:45, 1 April 2024 (UTC)

Military history articles must never default to start class. Hawkeye7 (discuss) 07:29, 1 April 2024 (UTC)

A-class reviews

The A-class review note currently accepts the following values:

• pass, keep, kept
• fail, demote, demoted
• current

I am wondering if we could change the "keep/kept" to "pass" and "demote/demoted" and "fail", in order to simplify this slightly? — Martin (MSGJ · talk) 13:17, 12 June 2024 (UTC)

Will make a bot request in a day or two — Martin (MSGJ · talk) 15:20, 16 June 2024 (UTC)

Unassessed military history articles

Category:Unassessed military history articles is full of Category talk, Template talk and File talk pages. These cannot be assessed. Would it be possible for them not to be placed in this maintenance category? Hawkeye7 (discuss) 05:39, 24 June 2024 (UTC)

@Hawkeye7: If you visit one of the miscategorised pages and perform a WP:NULLEDIT, then return to Category:Unassessed military history articles and reload it, the page that you nulledited disappears; visiting e.g. Category:Template-Class military history articles shows that the page has moved to the correct category. This tells me that the template code is presently working as intended.

What you are seeing is probably fallout from Wikipedia:Village pump (technical)#Weird ghost category redlinks. If you wait, they should all be fixed as the pages pass through the job queue, but it won't be straightaway as there are several hundred to fix. --Redrose64 🌹 (talk) 17:43, 24 June 2024 (UTC)

That cleared up that category, but I still have a problem with Category:Military history articles with no associated task force being cluttered with File and Draft space articles. Any chance of being able to remove them? Hawkeye7 (discuss) 23:24, 14 July 2024 (UTC)

This is now fixed. Hawkeye7 (discuss) 22:08, 17 August 2024 (UTC)

A class preload boilerplate

@MSGJ and Jonesey95: When you click on the "is currently undergoing" link to create a new A-class review, it is not preloading the template Wikipedia:WikiProject_Military_history/Review/A-Class_review_preload_boilerplate

It currently has

|action=edit

it should be:

|action=edit&preload=Wikipedia:WikiProject_Military_history/Review/A-Class_review_preload_boilerplate

Any assistance would be appreciated. Hawkeye7 (discuss) 10:14, 17 August 2024 (UTC)

@MSGJ and Jonesey95: Any ideas? I believe the following needs to be changed in Module:WikiProject_banner/templatepage. However, we really need another config parameter. Hawkeye7 (discuss) 05:50, 22 September 2024 (UTC)

---------------------------
-- Assessment link --------
---------------------------
if raw_args.class or raw_args.importance then
	local url = mw.uri.fullUrl(banner_name.prefixedText,{
		action = 'edit',
		summary = cfg_tp.assessment_link.edit_summary
	})
	if args.ASSESSMENT_LINK then
		if not mw.title.new(args.ASSESSMENT_LINK).exists then
			table.insert(notices, string.format(
				cfg_tp.assessment_link.missing,
				wikilink(args.ASSESSMENT_LINK),
				tostring(url),
				parameter_format('ASSESSMENT_LINK')
			))
		end
	end
end

Hawkeye7 (discuss) 06:12, 22 September 2024 (UTC)

Easy enough to add another parameter. What do you suggest, |ACR_BOILERPLATE=? — Martin (MSGJ · talk) 19:20, 22 September 2024 (UTC)

Sure. Can you make this change? I don't know how this is done. Hawkeye7 (discuss) 21:03, 22 September 2024 (UTC)

No problem. How about you fix your bot for PIQA and I'll do this for you :) — Martin (MSGJ · talk) 09:25, 23 September 2024 (UTC)

The bot has been fixed and now knows about our PIQA! A new C# version is now running on Toolforge! Hawkeye7 (discuss) 03:03, 9 October 2024 (UTC)

@MSGJ: Can you please fix this? A class nominations have dwindled because people do not know how to nominate them. (For some reason A-class=current isn't working at all any more.) Hawkeye7 (discuss) 22:33, 12 November 2024 (UTC)

I have started to code this in Module:WikiProject banner/auxiliary/sandbox. Not tested yet. Shouldn't take too long though — Martin (MSGJ · talk) 19:00, 14 November 2024 (UTC)

It seems to be working well. Can you try {{WikiProject Military history/sandbox}} and see if it's working as expected? There is also a test on Module talk:WikiProject banner/testcases — Martin (MSGJ · talk) 21:54, 14 November 2024 (UTC)

Yes, that works for me. Hawkeye7 (discuss) 02:17, 15 November 2024 (UTC)

Okay I will deploy it later today then — Martin (MSGJ · talk) 16:32, 15 November 2024 (UTC)

 Done — Martin (MSGJ · talk) 20:20, 15 November 2024 (UTC)

no-task-force

@MSGJ: Having a problem with Wikipedia talk:Manual of Style/Military history |no-task-force=yes but the 'No existing task force includes this article" error message is still appearing. Any ideas? Hawkeye7 (discuss) 20:06, 25 December 2024 (UTC)