Jump to content

Template talk:WikiProject Military history/Archive 2

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia
Archive 1Archive 2

Category:Military history draft pages

I think this template should be changed so that draft articles don't go into Category:Military history draft pages but instead go to Category:Draft-Class military history articles. The "Draft-Class" category fits in the rest of the Category:Military history articles by quality structure (and shows up in the template). It also allows for Category:Draft-Class military history articles by task force to be there in parallel with the other classes and the task forces as well. -- Ricky81682 (talk) 00:58, 16 October 2015 (UTC)

To give a better idea, Draft talk:John Cannon (American revolutionary) using WP US with "ARW" for a draft adds that to Category:Draft-Class American Revolutionary War articles. In contrast, Draft talk:137th New York Volunteer Infantry uses the ACW parameter but doesn't go into a corresponding Category:Draft-Class American Civil War articles. -- Ricky81682 (talk) 01:02, 16 October 2015 (UTC)
@Ricky81682: This is now being implemented; see Wikipedia talk:WikiProject Military history/Coordinators#Non-article assessment categories for more details. Kirill Lokshin (talk) 19:28, 2 November 2015 (UTC)

User-class subcategories

It doesn't look like User-class articles are going into the relevant task forces (assuming there's interest in that). For example, User talk:Ryan.opel/61st Army (Soviet Union) doesn't include Category:User-Class World War II articles as it would be in Category:Draft-Class World War II articles if this was in draftspace. -- Ricky81682 (talk) 21:44, 23 December 2015 (UTC)

This should be fixed on the template side now. Note that some of the categories are still being created, however. Kirill Lokshin (talk) 23:17, 23 December 2015 (UTC)
 Done It's fixed! Sorry about that then! -- Ricky81682 (talk) 00:49, 24 December 2015 (UTC)

User class doesn't show up when collapsed

Very, very minor thing but the user-class articles don't up when collapsed. In contrast to Talk:List of battleships which says "Rated:List-class", User talk:Bahamut0013/battleships doesn't indicate that it's User-class. Very dumb to care about but in case it's showing up with other classes, may as well mention it and move on. It may be the WikiProjectBannerShell template and if so, ignore me then. -- Ricky81682 (talk) 00:04, 3 June 2016 (UTC)

@Ricky81682: It looks like we never updated that part of the template when we added the new non-article classes. I've made the change now, so it should display properly regardless of what the rating is. Kirill Lokshin (talk) 01:21, 3 June 2016 (UTC)
Nice! Thanks! It's minutia but in case there were others, it's a flag. -- Ricky81682 (talk) 01:26, 3 June 2016 (UTC)

Ghost FA Classing

After the recent change on June 3rd, if an article is unassessed and in a Banner Shell it appears to get rated FA. Talk:Sydney March and Talk:São Marcelo Fort as examples. I can't see what is causing it. --Molestash (talk) 17:36, 4 June 2016 (UTC)

@Molestash: Now fixed. Kirill Lokshin (talk) 17:50, 4 June 2016 (UTC)

Template-protected edit request on 19 September 2016

{{!}}-
{{#ifeq:{{WikiProject Military history/Any|{{{Roman-task-force|}}}|{{{Roman|}}}|{{{Byzantine-task-force|}}}|{{{Byzantine|}}}}}|yes|
{{!}} style="width: {{#ifeq:{{WikiProject Military history/YesNo|{{{small|}}}}}|yes|28px|43px}};" {{!}} [[File:Roman Military banner.svg]]|{{#ifeq:{{WikiProject Military history/YesNo|{{{small|}}}}}|yes|28x20px|43x30px}}|center]]
{{!}} [[Wikipedia:WikiProject Military history/Roman and Byzantine Military History task force|Roman military history task force]] (c. 753–1453)<includeonly>{{WikiProject Military history/Task force categories|name=Roman military history |class={{{class|}}} |list={{{list|}}} |A-Class={{{A-Class|}}} |B-Class-1={{WikiProject Military history/YesNo|{{{B-Class-1|}}}{{{B-1|}}}{{{B1|}}}{{{b-1|}}}{{{b1|}}}}} |B-Class-2={{WikiProject Military history/YesNo|{{{B-Class-2|}}}{{{B-2|}}}{{{B2|}}}{{{b-2|}}}{{{b2|}}}}} |B-Class-3={{WikiProject Military history/YesNo|{{{B-Class-3|}}}{{{B-3|}}}{{{B3|}}}{{{b-3|}}}{{{b3|}}}}} |B-Class-4={{WikiProject Military history/YesNo|{{{B-Class-4|}}}{{{B-4|}}}{{{B4|}}}{{{b-4|}}}{{{b4|}}}}} |B-Class-5={{WikiProject Military history/YesNo|{{{B-Class-5|}}}{{{B-5|}}}{{{B5|}}}{{{b-5|}}}{{{b5|}}}}}}}</includeonly>
}}

I believe this is the correct code to add the roman military history task force to the parameters, but I am not 100% sure, if I am wrong could the correct parameters be added? Thanks. Iazyges Consermonor Opus meum 22:39, 19 September 2016 (UTC)

Done. Kirill Lokshin (talk) 23:34, 19 September 2016 (UTC)

Template-protected edit request on 20 October 2018

Please add the following to the parameters in alphabetical order to support the Indian military history task force: {{!}}- {{#ifeq:{{WikiProject Military history/Any|{{{Indian-task-force|}}}|{{{Indian|}}} {{!}} style="width: {{#ifeq:{{WikiProject Military history/YesNo|{{{small|}}}}}|yes|28px|43px}};" {{!}} [[File:Roundel of India.svg.svg]]|{{#ifeq:{{WikiProject Military history/YesNo|{{{small|}}}}}|yes|28x20px|43x30px}}|center]] {{!}} [[Wikipedia:WikiProject Military history/Indian military history task force|Indian military history task force]] <includeonly>{{WikiProject Military history/Task force categories|name=Indian military history |class={{{class|}}} |list={{{list|}}} |A-Class={{{A-Class|}}} |B-Class-1={{WikiProject Military history/YesNo|{{{B-Class-1|}}}{{{B-1|}}}{{{B1|}}}{{{b-1|}}}{{{b1|}}}}} |B-Class-2={{WikiProject Military history/YesNo|{{{B-Class-2|}}}{{{B-2|}}}{{{B2|}}}{{{b-2|}}}{{{b2|}}}}} |B-Class-3={{WikiProject Military history/YesNo|{{{B-Class-3|}}}{{{B-3|}}}{{{B3|}}}{{{b-3|}}}{{{b3|}}}}} |B-Class-4={{WikiProject Military history/YesNo|{{{B-Class-4|}}}{{{B-4|}}}{{{B4|}}}{{{b-4|}}}{{{b4|}}}}} |B-Class-5={{WikiProject Military history/YesNo|{{{B-Class-5|}}}{{{B-5|}}}{{{B5|}}}{{{b-5|}}}{{{b5|}}}}}}}</includeonly> }} Kges1901 (talk) 18:40, 20 October 2018 (UTC)

In addition, {{{South-Asian-task-force|}}}{{{South-Asian|}}}{{{Indian-task-force|}}}{{{Indian|}}}{{{Pakistani-task-force|}}}{{{Pakistani|}}} should be changed to remove {{{Indian-task-force|}}}{{{Indian|}}} so that 'Indian' goes to the new TF. Kges1901 (talk) 19:35, 20 October 2018 (UTC)
 Not done: The page's protection level has changed since this request was placed. You should now be able to edit the page yourself. If you still seem to be unable to, please reopen the request with further details. Primefac (talk) 13:31, 21 October 2018 (UTC)

Alignment of template on page

I know that there is a ton of customization on this template, but is there a reason why it is not centred like every other WikiProject banner? Can this be fixed? I've looked in the archives and it seems like whenever this disparity (or other differences) is mentioned, it just gets ignored. Primefac (talk) 23:03, 19 September 2019 (UTC) (please ping on reply)

Primefac, it looks like something changed the behavior of the raw messagebox CSS classes that this template was using. I've changed it over to use the same tmbox classes that {{WPBannerMeta}} uses, so it should now align correctly with any banner based on the latter. Kirill Lokshin (talk) 00:58, 20 September 2019 (UTC)
Sweet, thanks. Primefac (talk) 10:17, 20 September 2019 (UTC)

Auto-assess redirects?

Could this template be made to automatically apply the RDR quality class to redirects, like other WikiProject banner templates? A bot task I'm running removes the quality class from redirects - that way, the template will automatically update when someone makes the article no longer a redirect. For now, I've made the bot not touch any MILHIST banners, but if it's not too much of a pain, updating this template would be nice too. Enterprisey (talk!) 00:15, 15 April 2020 (UTC)

Template:WikiProject Military history/Class storing non-standard values

{{WikiProject Military history}} seems to prefer shorthand values for classifications, as opposed to the standards values. While I think staying consistent across all of Wikipedia is preferred, it's probably fine for each WikiProject to do its own thing. However in this case, the data ultimately gets passed to the {{#assessment}} parser function, so we end up with inconsistent values stored in the database. Consider quarry:query/55777. The large number of TMP, BK and DR values appear to be coming from this template when they should be storing the normalized values Template, Book and Draft, respectfully. It seems {{WikiProject Military history/Class}} is used before passing a value to the {{#assessment}} function, but it's also used for display purposes. So perhaps, then, we need a separate subtempalte to do the normalization just for the database (unless someone wants to update all the display logic). And while we're at it, we might consider reevaluating the need for some overly-specific classifications like BL (B-rated List) which in the standard system I think would simply be List. Save that for a different discussion, though.

Thoughts? — MusikAnimal talk 05:29, 8 June 2021 (UTC)

MusikAnimal, thanks for catching this—I hadn't realized that the internal class mnemonics were causing an issue on the database side. I've created {{WikiProject Military history/NormalizedClass}} to convert the internal class values into the standard ones prior to passing them to {{#assessment}}; the code also maps the advanced list classes (CL, BL, and AL) to the corresponding standard classes (C, B, and A). Please let me know if that fixes the problem, and if there's anything else that needs to be done. Kirill Lokshin (talk) 18:08, 8 June 2021 (UTC)
@Kirill Lokshin I'm not sure if that did it. quarry:query/55777 still shows a very high number of those same non-standard assessments. So there must be some other template using the {{#assessment}} parser function. I can't seem to figure it out. The results at quarry:query/55925 all seem to be using {{WPMILHIST}} or some variant of it. Any ideas? — MusikAnimal talk 18:34, 12 June 2021 (UTC)
MusikAnimal, do you know if the stored {{#assessment}} values are updated automatically (and, if so, how long that takes)? Or do they need a null edit to the talk page in order to get updated? Kirill Lokshin (talk) 18:44, 12 June 2021 (UTC)
@Kirill Lokshin I did some more testing, and yes it seems a null edit is apparently needed. However, the task forces must be storing the assessment separately, see for instance quarry:query/55927. That one I just did a null edit for, and I observed it fixed the value for "Military history" but not for the task forces. Once we get all the templates fixed, we can enlist a bot to do the null edits for us. — MusikAnimal talk 19:04, 12 June 2021 (UTC)
MusikAnimal, there's a separate {{#assessment}} tag inside {{WikiProject Military history/Task force categories}} that generates the task force assessments; I've updated that to use the normalized class value as well. Kirill Lokshin (talk) 19:26, 12 June 2021 (UTC)
Great! That should do it. I'll write a bot task to do the null edits. Thank you for your prompt assistance! — MusikAnimal talk 02:45, 14 June 2021 (UTC)
@Kirill Lokshin Sorry to bug you again… we're almost done! It looks like as far as WP Military History, the one outlier is Military history/Crusades task force. I can't figure out what template it's using to store assessments, but they are not being normalized at all, it seems. For instance quarry:query/55927 which now looks for Church of the Holy Sepulchre. It has one assessment of lowercase b when it should be B. When I look for other pages with lowercase assessments, they all are in the Crusades task force as well. — MusikAnimal talk 18:24, 17 June 2021 (UTC)
MusikAnimal, there's actually no {{WikiProject Military history}} instance on Talk:Church of the Holy Sepulchre; the Crusades assessment rating is being generated by {{WikiProject Middle Ages}}. I'm not sure why that template would be storing a non-normalized class, since it's based on {{WPBannerMeta}}. Kirill Lokshin (talk) 21:55, 17 June 2021 (UTC)
MusikAnimal, I think I've figured out the issue; there was a scenario where a lower-case class value input (i.e. |class=b) was being passed unchanged through both {{WikiProject Military history/Class}} and {{WikiProject Military history/NormalizedClass}}. I've made a change to address the issue, so please let me know if that fixes things on the database side. Kirill Lokshin (talk) 19:11, 18 June 2021 (UTC)
@Kirill Lokshin That did it! I think I confidently say the data is in good shape now :) Many thanks again for your help. — MusikAnimal talk 05:18, 21 June 2021 (UTC)

Why?

@Kirill Lokshin: I am trying to assess this article as C class using AWB, but even though I added it to C class but still it is showing [ https://wiki.riteme.site/w/index.php?title=Talk:3d_Light_Antiaircraft_Missile_Battalion&diff=767504874&oldid=766838698 Start class] when saving the page. What am I missing? Jim Carter 09:29, 26 February 2017 (UTC)

@Jim Carter: G'day Jim, for C class to display a number of the individual aspects of the B class checklist need to be completed. For instance, it must meet B1 (referencing) or B2 (coverage) as well as B3 (structure), B4 (grammar) and B5 (supporting materials). Each aspect would need to have a yes or a no next to it, e.g. "B1=y |B2=n|B3=y |B4=y |B5=y". Regards, AustralianRupert (talk) 10:21, 26 February 2017 (UTC)
This does not make sense. What then exactly is the point of C class if it has to meet the criteria for B Class? For example the criteria as stated here WP:MHA#SCALE for C Class "may still be incomplete or poorly referenced" would directly contradict this. Hzh (talk) 12:23, 30 October 2017 (UTC)
Looking further, I think I see the confusion, for C class you need either B1 or B2 to be "yes", but not if both are "no". Perhaps the wording could be clearer, i.e. not "may still be incomplete or poorly referenced", but "may either be incomplete or poorly referenced (one of the two criteria must be satisfactory)". Hzh (talk) 12:41, 30 October 2017 (UTC)
If I may follow up a 4 year old conversation: I agree that this is an exceptionally bizarre hidden property. In my experience tons of reviewers don't know this when they try to rate pages that are included in this WikiProject as a C, with the effect that the page appears to be a Start-class article even though the reviewer was trying to assign it a C. Does someone want this to be true, or is it just a technical peculiarity? - Astrophobe (talk) 19:46, 25 June 2021 (UTC)

list parameter

Is it possible to code the parameter "list" case-sensitive, so that writing "List" instead will work as well? Currently only "list" is accepted which constantly leads to incorrect assessments as articles instead of lists (also by the project's assessment-bot). ...GELongstreet (talk) 15:57, 25 December 2021 (UTC)

Missing file

This template tries to display File:PB Poland CoA.png with Polish-task-force=yes, but no such file exists (it was deleted on Commons). – Finnusertop (talk ⋅ contribs) 14:31, 9 January 2022 (UTC)

WPBS error

When housed inside {{WikiProject banner shell}}, this template seems to be putting empty space between it and the template above it, as seen at Talk:Robert J. O'Neill and Talk:Kevin St. Jarre. — Fourthords | =Λ= | 13:17, 12 June 2022 (UTC)

Fourthords, this is caused by extraneous whitespace within the template arguments passed to {{WikiProject banner shell}}, and can be fixed by removing that whitespace. Kirill Lokshin (talk) 17:28, 20 June 2022 (UTC)
That's strange, because it's a new glitch (I always use the leading whitespace with the WPBS) and only happens with this template. That's a good temporary fix, though, thanks! — Fourthords | =Λ= | 20:28, 20 June 2022 (UTC)

Considerations regarding a switch to WPBannerMeta

A switch to {{WPBannerMeta}} was floated on WP:VPR. The following items merit discussion:

  • A switch to project-independent quality ratings is being considered; its implementation should be scrutinized to see how it affects {{WikiProject Military history}}.
  • In the current MILHIST template, task forces are divided up in two groups, "general topics", and "nations and regions", which is quite clean. I don't believe WPBannerMeta supports that.
  • No matter what you put in |class=, if the MILHIST banner is on a template page, it will override and say: "Template-class".
    • On redirect pages, WPBannerMeta banners will automatically show "Redirect-class" if |class= is empty, but if |class=C is set, they'll happily say C-class, which leads to miscategorization. I don't know if WPBannerMeta supports the MILHIST banner's current behavior of overriding incorrect categorizations.
  • A WPBannerMeta version of MILHIST's banner is available in this template's {{WikiProject_Military_history/sandbox}}. It's not at feature-parity. For example, the sandbox version is still missing the B-criteria class mask (where an article rated |class=B|b1=no will automatically be shown as "C-class" due to the failed B1 criteria. This is very easy to implement in WPBannerMeta, but I don't have much time. I'm not sure if the current behavior of |class=C|b3=no leading to Start classification is supported by WPBannerMeta, but it should be.

DFlhb (talk) 14:09, 10 February 2023 (UTC)

Comments
  • Looks good. Better than I had hoped.
  • The sandbox version is still incomplete - periods and conflicts and special projects are missing. Need to check if it can support them all.
  • Looks like support for aclass is present. Will need to test this.
  • Switching to the new template should not require any bot runs.
  • I will run some test cases.

Hawkeye7 (discuss) 18:01, 10 February 2023 (UTC)

Yes, that sandbox version is still far from done. I don't know if I'll have time to bring it to complete feature parity (time isn't what I have the most of these days). DFlhb (talk) 10:09, 11 February 2023 (UTC)
I'll just keep adding notes here, for anyone who wants to work on the sandbox version.
  • The task force names were incomplete, so |US=yes worked, but |USAF=yes didn't. I think I added everything, but this should ideally be checked by at least two people besides me. Don't want to risk any omissions. These TF names are case sensitive, see this post. The non-WPBannerMeta main template is also case-sensitive for TF names.
  • Operation Majestic Titan is still not implemented. It should take in numbers from 1 to 5, not "yes/no", so either a custom parsing function should be written, or maybe there's one we can reuse.
  • I've still not implemented the B-criteria class mask, described in the last bullet point of my first post.
  • This article is not currently associated with a task force. To tag it for one or more task forces, please add the... is still not implemented.
  • I've not even taken a quick glance at the A-class implementation yet; it may be completely broken.
DFlhb (talk) 13:55, 11 February 2023 (UTC)
@DFlhb: Where did we get to with this? So should we go ahead with it? Hawkeye7 (discuss) 19:40, 15 March 2023 (UTC)
I've run into the limits of my very minimal template-editing knowledge, so I had to give it a rest. It's still missing support for OMT, B-criteria overrides (B3=no --> Start-class, even if |class=C), and I haven't done much testing for feature parity (wikibreak due to work). Wish I could've been more helpful DFlhb (talk) 11:21, 16 March 2023 (UTC)
I can help if needed, but currently tied up with the enhancements to the banner shell template. Let me know if there is something specific I can do? — Martin (MSGJ · talk) 20:27, 28 March 2023 (UTC)
See if you can find a way to support Operation Majestic Titan (OMT). We can forego the B-critieria overrides. Hawkeye7 (discuss) 18:07, 30 March 2023 (UTC)
It would be really helpful if you could help make {{WikiProject Military history/Class mask}} match the behavior of {{WikiProject Military history/Class}}, since it would ensure |list works correctly, and would probably ensure MilHistBot has no issues with the new version. Every other outstanding issue is likely easy to fix, but this one goes over my head.
I created {{WikiProject Military history/class}} that calls {{WikiProject Military history/Class mask}}, but maybe both can be combined into one. DFlhb (talk) 19:22, 4 April 2023 (UTC)

Says start class even though I set |class=C using rater

This WikiProject banner says start class even though I set |class=C using the rater script. Anyone know why? Talk:Red team. Thanks. –Novem Linguae (talk) 07:25, 7 May 2023 (UTC)

For MILHIST, C-class requires that B1 or B2 as well as B3 and B4 and B5 be met; per the assessment criteria at WP:MHA#CRIT — DFlhb (talk) 08:10, 7 May 2023 (UTC)
That seems unreasonably high tbh. Needing to meet all but 1 of criteria for B class just feels like it's basically "This article is almost B class but not quite". C class is meant to be a middle ground between Start and B class, not necessarily a placehoder (probably the wrong word) for articles that almost meet B class. ― Blaze WolfTalkBlaze Wolf#6545 22:02, 8 May 2023 (UTC)
It was what was agreed upon when the project adopted the C class rating. It was not clear what purpose C class was supposed to have. "This article is almost B class but not quite" has a purpose in that it targets articles that only need a little work to meet the project's minimum standard. Hawkeye7 (discuss) 22:19, 8 May 2023 (UTC)
Still, it feels high. Especially when on articles like Victory in Europe Day in which every other WikiProject has rated the article as C-class... except for MilHist. ― Blaze WolfTalkBlaze Wolf#6545 22:33, 8 May 2023 (UTC)
Yeah, this project seems a bit out of sync with the standard system, which is that stub/start/C can be assessed subjectively by anyone without any formal criteria, and ratings higher than that have formal criteria. Not a big deal though. Was just curious. –Novem Linguae (talk) 08:29, 9 May 2023 (UTC)

Status of WPBannerMeta sandbox version

This as a scratch pad (that anyone can edit) for bugs and missing features.

Fixed bugs are collapsed
Fixed by adding a bunch of |TF_X_HOOK to Template:WikiProject Military history/B-checklist categories
  • Categories are still applied even if category=no is set
Never mind, this is normal in templatespace. Always worked fine in talk page space.
  • If a B-criteria is missing, it should not be categorized as if it were failing. This is an awful default behaviour of Template:WPBannerMeta/hooks/bchecklist, and maybe the default should change.
Fixed with Template:WikiProject Military history/B-checklist categories
  • B-criteria don't show up with |class=list (nor their categories)
Should now show up for "list" and "List". Let me know if MILHIST is supposed to support other spellings, like maybe "L"
  • OMT not implemented
OMT now implemented, all 5 phases
  • B-criteria show up on Stub-class if one B-criteria is filled; main template only shows it on B, BL, CL, CL, Start, List regardless of whether they're filled.
Fixed in this diff
  • B-criteria show on redirects (??)
Fixed in this diff
  • B-class mask not setup
The B-criteria now correctly override the stated class based on b1-b5, thanks to the custom reimplementation of {{class mask}} at Template:WikiProject Military history/Class mask. Behaviour matches the main template.
  • B-checklists showed up on userspace, unlike the main template
Fixed in this diff
  • "not currently associated with a task force" question mask isn't properly centred
Fixed in this diff
Fixed inline in this diff and this diff.
  • The needing attention only to categories aren't implemented
Fixed pretty elegantly in this diff.
  • A-Class parameter values keep and kept not implemented
Fixed by creating Template:WikiProject Military history/aclass
  • There's a strange blank line above the collapsed "More information:" at the bottom of the banner. No idea what causes it.
Fixed in this diff
Looks like the main template does behave like that. I was mistaken.
  • A-class categories fail to override incorrect passed-in parameters (e.g. articles are not categorized Military history articles needing attention to tagging even if they lack a valid SUBPAGE_LINK).
This and related bugs were fixed in these diffs
  • OMT categories show up even if |category=no
Fixed in this diff
  • Lists aren't implemented; the |list behavior doesn't work.
  • Namespace class overrides aren't implemented
  • Class mask doesn't work properly for lists; it doesn't normalize |class=C|list=y as identical to |class=CL|list=y
  • Class overrides are still not fully implemented; just the B-checklist. A-Class = pass doesn't override |class=GA.
All four bugs above have been fixed with these diffs (calling Teplate:MILHIST/Class inline instead of using the subpage method, which AFAIK doesn't support passing in |list or |A-Class)
  • Bug: it should only categorize (based on B-criteria) in "needing attention only to..." for the main cat, not for the task force cats.
That was actually an easy fix.
Was caused by a bug in Template:WikiProject Military history/B-checklist categories, which is no longer used.

DFlhb (talk) 10:23, 3 April 2023 (UTC)

  • Does this mean that everything is working now? We can implement? Hawkeye7 (discuss) 02:10, 4 April 2023 (UTC)
    Keep in mind I'm a noob who's learning template syntax for the first time by doing this; so expect it to be a little rough. I wouldn't feel comfortable without someone else double-checking. Above, I've listed the bugs I found. DFlhb (talk) 02:15, 4 April 2023 (UTC)
    Also, seems WPBannerMeta only supports one portal. No idea how to fix. DFlhb (talk) 20:49, 4 April 2023 (UTC)
    It does only support one main portal, but each taskforce may also have a portal. If you want two or more main portals, you need to code for it specially, see Template:WikiProject Trains/testcases. --Redrose64 🌹 (talk) 22:23, 4 April 2023 (UTC)
    I think we want neither, since these are neither project portals, nor aligned with task forces (for example, there's a Battleships portal but no Battleships task force). The banner should support receiving |portalX-name and portalX-link (1-5) parameters and display the portal if passed in, and AFAIK the only way to do that is through a hook. Since I can't find one, I'm trying to make one, using code from {{WPBannerMeta/hooks/notes}} as inspiration, but as you can imagine it's a challenge. DFlhb (talk) 22:33, 4 April 2023 (UTC)
    (done, though I did it inline and messy; but at least it works) DFlhb (talk) 00:06, 5 April 2023 (UTC)
    @Hawkeye7 @MSGJ
    I can't believe it, but I think everything now works. Would still appreciate if someone checked; and I do apologize for the code being messy, this is the only way I could find of reaching feature parity. DFlhb (talk) 05:38, 6 April 2023 (UTC)

I have added the module to check for unknown parameters to the sandbox version of the template (diff) in anticipation of the conversion to WPBannerMeta. Any pages using unknown parameters will be categorized in Category:Pages using WikiProject Military history with unknown parameters (unless |category=no is set). Harryboyles 01:16, 21 May 2023 (UTC)

@DFlhb: Can this be implemented now? What will happen if someone makes a change like this? Hawkeye7 (discuss) 03:14, 1 July 2023 (UTC)

The template has been ready since April; sorry, I should have made that clearer above. I've tested it thoroughly and fixed a few bugs in the task forces and categories, but a few may inevitably remain. Do you know of a tool that could monitor category membership counts? That could help check for categorization bugs after deployment.
This is a problem. Best solution I can think of is for MilHistBot to store every article's class in a JSON, so it can detect whether an article has never been rated, or has just had its rating deleted. The alternative is to do it manually as you did there, which I'm sure you'd rather avoid. @MSGJ:, this is another good reason to do the article-class-conversion bot run ASAP, because I'm now seeing a bunch of people doing it manually, and we can't expect them to know which projects have opted out. That'll be a problem for all these projects that don't have a bot to do the JSON thing. DFlhb (talk) 14:27, 1 July 2023 (UTC)
I will upgrade the MilHistBot to handle this situation. I was hoping that we would inherit the rating from the BannerShell like other projects do. Hawkeye7 (discuss) 21:11, 9 July 2023 (UTC)
The bot could also try to address this, by removing parameters deprecated a decade+ ago like |attention DFlhb (talk) 08:12, 10 July 2023 (UTC)
@Hawkeye7 the WPBannerMeta version has now been deployed, after even more testing. I'll announce it on the MILHIST talk page so people know to be on the lookout for any bugs. DFlhb (talk) 10:11, 8 July 2023 (UTC)

TF_n_NAME

Please could someone add this parameter for each task force? It is needed for the PageAssessments database to be populated properly — Martin (MSGJ · talk) 18:57, 9 July 2023 (UTC)

Done. DFlhb (talk) 09:12, 10 July 2023 (UTC)
Thanks — Martin (MSGJ · talk) 10:02, 10 July 2023 (UTC)

MILHIST A-Class preload

@DFlhb: When you clicked on "is currently undergoing" when creating an A-Class nomination, the page used to be preloaded with certain information from WP:WikiProject Military history/Review/A-Class_review_preload_boilerplate. The code was:

[{{Template:WikiProject Military history{{{1|{{PAGENAME}}}}}|action=edit&preload=Wikipedia:WikiProject_Military_history/Review/A-Class_review_preload_boilerplate}} {{color|red|currently undergoing}}]}}

Would it be possible to change the code on the TEXT card in Template:WikiProject Military history/aclass to restore this functionality?

I'm thinking:

This article '''[{{fullurl|{{{SUBPAGE_LINK}}}|action=edit&preload=Wikipedia:WikiProject_Military_history/Review/A-Class_review_preload_boilerplate}} is currently undergoing]''' an [[{{{REVIEW_LINK}}}|A-Class review]].

Would that work?

Hawkeye7 (discuss) 20:47, 3 August 2023 (UTC)

This ought to work. The code you propose works too, but would show all links as blue even if the subpage page doesn't exist; would that be desirable? DFlhb (talk) 00:58, 4 August 2023 (UTC)
That did not escape my notice; I considered {{color|red|currently undergoing}}. But I prefer your version. Hawkeye7 (discuss) 02:23, 4 August 2023 (UTC)
@Hawkeye7 and DFlhb: - has this been resolved? I was going to open a second nomination for John Bullock Clark but the preload still isn't present. Hog Farm Talk 00:49, 26 November 2023 (UTC)
It works for |A-Class=current, but not |A-Class=fail, which matches previous behavior; gotta switch it to "current" first DFlhb (talk) 06:09, 26 November 2023 (UTC)

WPBannerMeta/hooks/taskforces

This template is still using Template:WPBannerMeta/hooks/taskforces which is no longer supported and has not kept up with all the updates on Module:WikiProject banner. I would like to update them. The only part that is not currently supported would be the separate headings, e.g. Associated task forces (general topics). How attached are you to these? — Martin (MSGJ · talk) 09:40, 13 December 2023 (UTC)

Proposed code on sandbox — Martin (MSGJ · talk) 22:05, 14 December 2023 (UTC)

Nested names

Please consider using the tfnested hook to display the names of the task forces in the nested version — Martin (MSGJ · talk) 20:17, 28 July 2023 (UTC)

Code on sandbox will display the names of the task forces in nested version — Martin (MSGJ · talk) 23:18, 15 December 2023 (UTC)
 Done — Martin (MSGJ · talk) 08:22, 16 December 2023 (UTC)

Template-protected edit request on 16 December 2023

In Template:WikiProject Military history the parm "TF_14_NESTED = Weaponry" is duplicated, giving an error. The 2nd one should be removed. Davemck (talk) 15:16, 16 December 2023 (UTC)

 Done SWinxy (talk) 19:09, 16 December 2023 (UTC)

Disambiguation pages

This template uses "disambig" for disambiguation pages but some other projects are using "disambiguation". This causes some editors to enter "disambiguation" instead of "disambig" eg Talk:Battle of Tallinn, Talk:German occupation of Estonia, Talk:Partisans in the Baltic States. How hard would it be to have our template accept both? Hawkeye7 (discuss) 00:40, 9 January 2024 (UTC)

It's a discrepancy between how Template:WikiProject Military history/Class works and how Template:WPBannerMeta and its modules work.
The former has two lines like this: 
|dab|disambig=DAB
which respects the values dab and disambig (case-insensitive).
The latter respects the values disambiguation, disambig and dab (again case-insensitive), and have done for some years; more recently, they have been amended to autodetect that the subject page is a disambiguation page, but I'm not sure if it's done by looking for a template tag like {{disambig}} or the presence of the page in Category:Disambiguation pages or its subcats.
It should be noted that Template:WikiProject Military history is now built around Template:WPBannerMeta and so using |class=disambiguation will cause a mixture of effects. I shall elaborate if asked. --Redrose64 🌹 (talk) 09:38, 9 January 2024 (UTC)
Module:WikiProject banner calls Module:Class mask which in turn calls Module:Disambiguation. That module checks the article's content for the presence of disambiguation templates calls (comparing against the list at Module:Disambiguation/templates). This means that in most disambiguation articles, WikiProject banners using standard quality assessments ignores the class parameter entirely. Harryboyles 16:04, 9 January 2024 (UTC)
Since Template:WikiProject Military history is built around Template:WPBannerMeta does Template:WikiProject Military history/Class need to process disambiguation pages or can it be left to the default? Hawkeye7 (discuss) 20:39, 9 January 2024 (UTC)

Category:Military history articles needing attention to tagging

Does anyone know how articles wind up in Category:Military history articles needing attention to tagging? I've looked at a couple and cannot see anything wrong with them. Hawkeye7 (discuss) 03:37, 10 January 2024 (UTC)

The articles get put into this category if the {{WikiProject Military history}} call includes the A-Class parameter and either:
  1. There hasn't actually been an A-class review started (i.e. Wikipedia:WikiProject Military history/Assessment/**Name of nominated article** doesn't exist).
  2. The value of the A-Class parameter isn't one of pass|keep|kept|fail|demote|demoted|current (most commonly |A-Class=no)
There were two pages which did have an A-class assessment subpage, but the category hadn't refreshed. Per step 7 of the instructions at Wikipedia:WikiProject_Military_history/Assessment/A-Class_review, a null edit cleared the category from these two pages. Harryboyles 08:01, 10 January 2024 (UTC)
I've just added some explanation to Category:Military history articles needing attention to tagging Harryboyles 08:12, 10 January 2024 (UTC)
I think they all have A-Class assessment subpages. What has happened is that the article was renamed after the A-Class review. This is noted in the ArticleHistory. Do we need to create redirects to remove the articles from the category? Or can it be made smarter? Is it possible to inform the the template? Hawkeye7 (discuss) 21:42, 10 January 2024 (UTC)
Redirect is probably the simplest fix - just created a redirect: Wikipedia:WikiProject Military history/Assessment/57th Rifle Division -> Wikipedia:WikiProject Military history/Assessment/57th Rifle Division (Soviet Union). Doing a null edit on Talk:57th_Rifle_Division afterwards cleared the category. Harryboyles 06:37, 11 January 2024 (UTC)

Category:Military history lists incorrectly assessed as articles

These articles are listed as being incorrectly assessed as articles instead of lists, but class=list. Looks like a problem with the template. Hawkeye7 (discuss) 23:25, 16 January 2024 (UTC)

According to the template documentation, |list=yes is required to be added as a parameter in order to apply the list-based assessment criteria. Harryboyles 08:27, 17 January 2024 (UTC)
Retrieved from "https://wiki.riteme.site/w/index.php?title=Template_talk:WikiProject_Military_history/Archive_2&oldid=1240811603"