Jump to content

Template talk:4TeamBracket-Tennis3

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia

Template-protected edit request on 10 March 2022

[edit]

Reduce the height of 1st and 4th team brackets. Changes made in sandbox (diff). Thanks, Qwerty284651 (talk) 20:43, 10 March 2022 (UTC) Qwerty284651 (talk) 20:43, 10 March 2022 (UTC)[reply]

Don't know. Things look a bit scrunched on the test cases page. Why should the height be reduced? P.I. Ellsworth - ed. put'r there 03:29, 11 March 2022 (UTC)[reply]
Because it looks more compact. With players with long last names, who have deep runs in tournaments, example, it can be a bit clogged up and stretched out. Hence, why it'd be good if it were compact. Qwerty284651 (talk) 09:43, 11 March 2022 (UTC)[reply]
That's confusing because for one thing, this template isn't used on the page you gave as an example; there they use {{8TeamBracket-Tennis3}} and {{16TeamBracket-Compact-Tennis3-Byes}}. For another thing, this template invokes a module and your sandbox code does not. If this different height is wanted, then shouldn't it be changed in the module? Do we really want to stop using Module:Team bracket just to change the height? P.I. Ellsworth - ed. put'r there 17:04, 11 March 2022 (UTC)[reply]
How about this diff? My goal is to reduce the height in {{{RD1-seed2|}}}, so that all teams' brackets are of the same height, or at least come close to it visually, without standing out too much, see testcase: Example 2, when compared to the original in Example 1. I have never messed with a Module's TemplateData before, so I wouldn't know how to change the height there. It is too advanced for me at the moment. Any suggestions where to start in the module's code? Qwerty284651 (talk) 23:31, 11 March 2022 (UTC)[reply]
Be sure to read H:DL where it explains why we don't use semicolons just to bold a line anymore. I can't find any difference between examples 1 and 2, sorry. I don't know enough about the Lua module code to help here. You might try discussing it with the creators and other editors of the module to find out what's possible and acceptable. It's probable that they would not want this to devolve into non-usage of the module. P.I. Ellsworth - ed. put'r there 01:54, 12 March 2022 (UTC)[reply]
@Paine Ellsworth Could you change the height of the template from Example 2 diff. Then I will ask on Module's talk page to have them implement the change in Lua. Qwerty284651 (talk) 01:57, 17 March 2022 (UTC)[reply]
Would rather this be asked on the module's talk page first, so that this template's code does not need to revert back to pre-module code. Sorry Qwerty284651, but your suggestion is seen as "cart before horse". Change the height in the module and this template will follow. P.I. Ellsworth - ed. put'r there 07:20, 17 March 2022 (UTC)[reply]
@Paine Ellsworth very well. Will do as you say. Qwerty284651 (talk) 08:37, 17 March 2022 (UTC)[reply]

Edit request 1 September 2022

[edit]

Remove the parameters |RD1-seed1=, |RD1-seed2=, etc. They are not needed, and they do not allow the alternate parameters |RD1-seed01=, |RD1-seed02=, etc. to be used. @Frietjes: unless I am mistaken, we could also remove a bunch of other redundant parameters, correct? (e.g., |seeds=, |compact=, |RD1=) – Pbrks (t • c) 15:49, 1 September 2022 (UTC)[reply]

Pbrks, you are correct, now removed. the default blanking of the seeds was leftover from when the default was to auto populate the seeds for the first round, but that is no longer the default. Frietjes (talk) 15:53, 1 September 2022 (UTC)[reply]