Module talk:OSM Location map

Module:OSM Location map is permanently protected from editing because it is a heavily used or highly visible module. Substantial changes should first be proposed and discussed here on this page. If the proposal is uncontroversial or has been discussed and is supported by consensus, editors may use {{edit template-protected}} to notify an administrator or template editor to make the requested edit.

Preparing to go live with replacement for the wiki-template version

I have finally got to grips with enough of Lua/Scribuntu to convert the whole of the existing suite of {{OSM Location map}} templates to into a Lua module. The intention here is to retain complete 'functional equivalence', but for various reasons there may be tiny shifts in position of some elements, which I would propose to 'leave be'. Differences which have a significant impact on existing maps, or throw up errors, will need to be addressed before going live, if at all possible.

The main objectives in this rewrite are:

Better performance/lower resource use. The maps via the module are making much lower demands on the resources and load-times.
Enable 'notionally unlimited' amount of dots, instead of the 60 limit. Clearly there would be a point beyond which the resources will be affected, but the module has no built in limit.
Use of Lua will make it possible to add features within more maintainable code.
Also to develop an alternative more condensed parameter regime, to give more flexibility/control options and more concise template text (and one day, maybe external data file).

This last point will be a thing to look at in detail later on. The first task at this point is to test out any potentially troublesome maps before going live, so any help in checking maps would be much appreciated.

{{OSM Location map/sandbox}} is now using the new module, so you can test a map 'in-situ' by simply adding '/sandbox' to the template name and preview it. (Note: don't leave it saved with the sandbox version, as it might be being used later for testing stuff). If you find errors the next step is to paste the full template code into a 'testcases table' template at {{OSM Location map/testcases}}. This allows side-by-side comparison of how it is supposed to look, so the issue can be debugged. My suggestion is that you notify about problem maps on this talk page, which is also a good place to initiate any other discussions on the switch-over to using the module

Thanks for any input people can make. RobinLeicester (talk) 23:34, 5 March 2025 (UTC)[reply]

A test case identified that module is not parsing extended character set for labels and only displaying ASC11 character set. This will break many maps. I will paste an example as this is breaking till fixed. ChaseKiwi (talk) 08:39, 8 March 2025 (UTC)[reply]

Test for full character set in labels and correct labelling positioning

The bugs at time of initial testing in Test case are:

Lua module not displaying full character sets in labels
number code labels misaligned
1. lapel position top about 5px to high
2. label 2 which was on a CurveC goes mad with the ldy2 = 16 by probably a factor of ten

8km
5miles

M

ý

r

d

a

l

s

j

ö

k

u

l

K

ö

t

l

u

j

ö

k

u

l

C20

C15

C14

C13

C12

C11

C10

C18

C16

C9

C17

C8

C19

C7

C6

C5

C4

C3

C2

C1

8

7

6

5

4

3

2

1

CURRENT CODE Arrows show recent jökulhlaup flows from Mýrdalsjökull ice cap. Current ice cauldrons are shown in violet:^[1]^[2]^: 17^[a]^[b]
1:from Kötlujökull to Leirá in 1721, 1755, 1918
2:from Kötlujökull / Sandfellsjökull to Austastikælir stream / Skálm river in 1612, 1625, 1660, 1721, 1755, 1823, 1860, 1918, 2024^[3]
3:from Kötlujökull to Blautakvísl river area of Mýrdalssandur in (1625), 1660, 1755, 1823, 1918
4:from Kötlujökull to Múlakvísl river area of Mýrdalssandur towards Kötlutangi and Höfðabrekkufjara beaches in 1612, 1625, 1660, 1721, 1755, 1823, 1860, 1918
5:from Kötlujökull to Múlakvísl river area of Mýrdalssandur towards Höfðabrekkufjara beach in 1612, 1625, 1660, 1721, 1755, 1823, 1860, 1918, 1955, 1999, 2011, 2014, 2017
6:from Múlakvísl river area towards Kerlingardalsfjara beach in 1660, 1721, 1755, 1823, 1860
7:from Sólheimajökull towards Sólheimasandur in 1860, 1999
8:from Jökulsárgilsjökull towards Jökulsárgil in 1936

7km
4miles

M

ý

r

d

a

l

s

j

ö

k

u

l

K

ö

t

l

u

j

ö

k

u

l

C20

C15

C14

C13

C12

C11

C10

C18

C16

C9

C17

C8

C19

C7

C6

C5

C4

C3

C2

C1

8

7

6

5

4

3

2

1

NEW LUA MODULE TEST CASE Arrows show recent jökulhlaup flows from Mýrdalsjökull ice cap. Current ice cauldrons are shown in violet:^[1]^[2]^: 17^[a]^[b]
1:from Kötlujökull to Leirá in 1721, 1755, 1918
2:from Kötlujökull / Sandfellsjökull to Austastikælir stream / Skálm river in 1612, 1625, 1660, 1721, 1755, 1823, 1860, 1918, 2024^[3]
3:from Kötlujökull to Blautakvísl river area of Mýrdalssandur in (1625), 1660, 1755, 1823, 1918
4:from Kötlujökull to Múlakvísl river area of Mýrdalssandur towards Kötlutangi and Höfðabrekkufjara beaches in 1612, 1625, 1660, 1721, 1755, 1823, 1860, 1918
5:from Kötlujökull to Múlakvísl river area of Mýrdalssandur towards Höfðabrekkufjara beach in 1612, 1625, 1660, 1721, 1755, 1823, 1860, 1918, 1955, 1999, 2011, 2014, 2017
6:from Múlakvísl river area towards Kerlingardalsfjara beach in 1660, 1721, 1755, 1823, 1860
7:from Sólheimajökull towards Sólheimasandur in 1860, 1999
8:from Jökulsárgilsjökull towards Jökulsárgil in 1936

Thanks, ChaseKiwi. Both issues fixed, I think. Not sure if my fix for the label positions will work in all sizes and angles, but seems to hold up pretty well. I will also look further at extended character set risk. Please add anything that looks off. Much obliged, RobinLeicester (talk) 01:16, 10 March 2025 (UTC)[reply]

References

^ ^a ^b Cite error: The named reference hi was invoked but never defined (see the help page).
^ ^a ^b Cite error: The named reference McCluskey2019 was invoked but never defined (see the help page).
^ ^a ^b "Hlaup úr Mýrdalsjökli. Hlaupið hefur ekki náð hámarki við þjóðveg 1" (in Icelandic). Icelandic Weather Office. 28 July 2024. Retrieved 28 July 2024.

script errors

@RobinLeicester there might be some issues for you to attend to in Category:Pages with script errors. For example, 2003 Casablanca bombings reports:

Lua error in Module:OSM_Location_map at line 406: bad argument #1 to 'rad' (number expected, got string).

TIA. --Joy (talk) 18:27, 21 March 2025 (UTC)[reply]

Thanks for that. Hopefully the issue is fixed, but if other issues are showing up, please let me know. Much appreciated. RobinLeicester (talk) 23:53, 21 March 2025 (UTC)[reply]

Lua error at Killing of Brian Thompson

Could someone please look into the Lua error at Killing of Brian Thompson#Timeline? I tried but found myself hopelessly lost. * Pppery * _{it has begun...} 16:01, 22 March 2025 (UTC)[reply]

Thanks Pppery. It turns out to have just been the lessthan comparison falling over when given letters instead of numbers, for which I apologise. Thanks for having a look. The 'sort' stuff is horribly convoluted but turns out to not be the guilty party. RobinLeicester (talk) 00:15, 23 March 2025 (UTC)[reply]

Cite error: There are <ref group=lower-alpha> tags or {{efn}} templates on this page, but the references will not show without a {{reflist|group=lower-alpha}} template or {{notelist}} template (see the help page).

[hi-1] Cite error: The named reference hi was invoked but never defined (see the help page).

[McCluskey2019-2] Cite error: The named reference McCluskey2019 was invoked but never defined (see the help page).

[IWOJuly2024-5] "Hlaup úr Mýrdalsjökli. Hlaupið hefur ekki náð hámarki við þjóðveg 1" (in Icelandic). Icelandic Weather Office. 28 July 2024. Retrieved 28 July 2024.

[1]

[2]

[a]

[b]

[3]